Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace testcontainers with "something else"? #62

Closed
erikgb opened this issue Oct 4, 2023 · 3 comments · Fixed by #65
Closed

Replace testcontainers with "something else"? #62

erikgb opened this issue Oct 4, 2023 · 3 comments · Fixed by #65

Comments

@erikgb
Copy link
Member

erikgb commented Oct 4, 2023

I think the testcontainers tests are slow, and we will also be affected by the DockerHub rate limits. There are some suggestions in testcontainers/testcontainers-java#3099, but I personally think we could/should test this without containers. What about an in-memory embedded broker?

@sverrehu
Copy link
Contributor

sverrehu commented Oct 5, 2023

I have the code ready now, just need to figure out how to release a jar file. But that must be another day.

@erikgb
Copy link
Member Author

erikgb commented Oct 5, 2023

Why don't we use an embedded Kafka broker created and maintained by someone else?

@sverrehu
Copy link
Contributor

sverrehu commented Oct 5, 2023

Those I found were either not updated for years, or delegated the embedding to testcontainers.

At least I had fun creating my little project, which I think is the absolute minimum required to embed a Java server. Including formatting the Kafka log directory (required for KRaft) without running an external command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants