Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Show "after saving" actions when revisions are enabled #9357

Merged
merged 6 commits into from
Jul 16, 2024

Conversation

duncanmcclean
Copy link
Member

This pull request adds the "after saving" actions which are missing when editing entries in a collection with revisions enabled.

I've added the "after saving" actions to both the save & publish buttons:

CleanShot 2024-01-18 at 17 36 04

Fixes #6025.

@jasonvarga
Copy link
Member

jasonvarga commented Jan 19, 2024

I get why you added the dropdown to both buttons but it just seems like an odd pattern. @jackmcdade ?

Especially when you choose an option on one button, the other button shows the old selection's icon.

CleanShot 2024-01-19 at 14 43 37

@duncanmcclean
Copy link
Member Author

Yeah, I don't love it being on both buttons either but figured you might want to go either way. Happy to tweak it though.

@jasonvarga
Copy link
Member

I think we should add the dropdown to the publish form (so it acts like the blue save & publish button when not using revisions) and just make the save button stay on the page.

Closing to stay organized. If you want to reopen, please target v5.

@jasonvarga jasonvarga closed this May 8, 2024
…ons-when-using-revisions

# Conflicts:
#	resources/js/components/entries/PublishForm.vue
We just want the save options on the "Publish" button.
@duncanmcclean duncanmcclean reopened this May 13, 2024
@duncanmcclean duncanmcclean changed the base branch from 4.x to 5.x May 13, 2024 10:26
@duncanmcclean duncanmcclean changed the title [4.x] Show "after saving" actions when revisions are enabled [5.x] Show "after saving" actions when revisions are enabled May 13, 2024
@duncanmcclean
Copy link
Member Author

I think we should add the dropdown to the publish form (so it acts like the blue save & publish button when not using revisions) and just make the save button stay on the page.

Closing to stay organized. If you want to reopen, please target v5.

Good idea, updated!

CleanShot 2024-05-13 at 11 27 30

@jasonvarga jasonvarga merged commit be7728e into 5.x Jul 16, 2024
16 checks passed
@duncanmcclean duncanmcclean deleted the show-after-saving-actions-when-using-revisions branch July 16, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After enabling revisions you can't select "after saving" actions
2 participants