Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Fix issue if submitted password is null #10945

Merged
merged 3 commits into from
Oct 14, 2024
Merged

[5.x] Fix issue if submitted password is null #10945

merged 3 commits into from
Oct 14, 2024

Conversation

aerni
Copy link
Contributor

@aerni aerni commented Oct 12, 2024

This PR resolves an issue that would occur if you clicked the submit button on the password protect page without having entered a password.

Issue before PR

CleanShot 2024-10-12 at 18 04 46@2x

After PR

CleanShot 2024-10-12 at 18 05 17@2x

jasonvarga
jasonvarga requested changes Oct 14, 2024
View reviewed changes
Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately changing method signatures like this is a breaking change.

Please update the controller instead.

@aerni aerni requested a review from jasonvarga October 14, 2024 15:47
@jasonvarga jasonvarga merged commit 9a966ea into statamic:5.x Oct 14, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonvarga jasonvarga Awaiting requested review from jasonvarga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aerni @jasonvarga