[5.x] Adds Boolable interface to resolve issues with ArrayableString instances in conditions under some circumstances. #10595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #10589 and replaces #10593 and implements the idea in this comment #10593 (comment). The root cause of the linked issue is that passing values to a tag using the
:some_var="var_name"
syntax removes the wrapperValue
object. In the case ofLabeledValue
, this will ultimately resolve a value similar to the following when doing the "truthiness" check:This PR introduces a new
Boolable
interface which is now used by the underlyingArrayableString
to help Antlers make decisions when performing truthiness checks.