[5.x] Always detach localizations when user is missing permissions to delete in other sites #10587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're already forgetting this key in the `deleteDescendants` method above. Without doing it here too, the action will error out when deleting the actual entry, since it thinks the localizations are still attached.
jasonvarga
requested changes
Aug 7, 2024
jasonvarga
approved these changes
Aug 8, 2024
jasonvarga
deleted the
prevent-deleting-entries-in-other-sites-without-permission
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where it was possible for users to delete localized entries in other sites, even if they don't have permissions to access that site.
Fixes #10519.