[5.x] Sanitize asset folder name on creation #10577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
We could just call the rule |
|
Renamed the validation rule, ready from my end :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uploading assets, the filenames are automatically sanitized. This does the same for asset folders.
Closes statamic/ideas#503
Current behavior
Currently a completely valid folder name is required when creating/moving/renaming folders. Spaces in folder names lead to validation errors and require manual correction. This quickly becomes exhausting when editors need to create dozens of folders by copy-pasting from their local filesystem.
Behavior after this change
With this change, folder name inputs allow spaces. For that, it introduces a new rule for valid folder name inputs: same as
alpha_dash, but with spaces allowed. The spaces are then removed by re-using the basename sanitizer from theFileUploaderclass, which also sanitizes upload filenames. Handles creation and renaming/moving.Notes
Wasn't sure about the rule nameAllowedFolderas it implies a check for a valid filesystem directory name, when actually it validates the pre-sanitized input value of folder name inputs.