-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x] Starter kit modules and other misc improvements #10559
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is looking very promising. I'll try to find some time soon to have a go with this. ❤️ |
Posting the docs screenshot I got from @jesseleite here. As it explains everything in this PR very well: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo
modules
configs as optional modulesexport
export_as
dependencies
dependencies_dev
Yes / No
, to a single module)A or B
, say to select between multiple JS framework options, etc.)No
option forselect
prompt modulesprompt: Custom Text
label: Custom Text
forselect
module optionsskip_option: Custom Text
forselect
module skip optionprompt: false
always install a module-n
tooPrompt::fake()
with$this->artisan()
pending commands?Required a workaround for now...Prompt::fake()
incompatible withPendingCommand
created by$this->artisan()
? laravel/prompts#158expectsQuestion()
style command helpers.expectsChoice()
if/when this gets tagged [11.x] MakeexpectsChoice
assertion more intuitive with associative arrays. laravel/framework#52408export_as
logic inside of modulesFor future PRs...
I intentionally designed the module looping, so that we could more easily do things like this in the very near-future...