Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Starter kit modules and other misc improvements #10559

Merged
merged 47 commits into from
Aug 13, 2024

Conversation

jesseleite
Copy link
Member

@jesseleite jesseleite commented Aug 2, 2024

Todo

  • Installer
    • Handle nested modules configs as optional modules
      • Ensure all modules work with same options as top level config
        • export
        • export_as
        • dependencies
        • dependencies_dev
      • Module types
        • Confirmation module (Yes / No, to a single module)
        • Select module (A or B, say to select between multiple JS framework options, etc.)
    • Handle top level config as a module
    • Handle nested modules
    • Ensure hitting enter skips all modules
      • Default No option for select prompt modules
    • Allow custom prompt text via prompt: Custom Text
      • Handle label: Custom Text for select module options
      • Handle skip_option: Custom Text for select module skip option
    • Make prompt: false always install a module
      • Ensure this works non-interactively with -n too
    • Tests
  • Export command
    • Handle export_as logic inside of modules
    • Handle top level config as a module
    • Handle nested modules
    • Handle dependency versioning
    • Tests
  • Docs PR

For future PRs...

I intentionally designed the module looping, so that we could more easily do things like this in the very near-future...

  • Folder based configs
  • External starter-kit module repo configs
  • Per-module PostInstallHooks

@jesseleite jesseleite marked this pull request as ready for review August 8, 2024 22:43
@robdekort
Copy link
Contributor

This is looking very promising. I'll try to find some time soon to have a go with this. ❤️

@robdekort
Copy link
Contributor

Posting the docs screenshot I got from @jesseleite here. As it explains everything in this PR very well:
CleanShot_2024-08-09_at_11 14 01

@jasonvarga jasonvarga merged commit c6180f6 into 5.x Aug 13, 2024
17 checks passed
@jasonvarga jasonvarga deleted the feature/improved-starter-kits branch August 13, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants