Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Minor dark mode adjustments #10544

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

heidkaemper
Copy link
Contributor

This pull request brings a few minor adjustments for dark mode:

  • The "little-dot" for indicating the publishing status gets a darker shade of grey. (will be the same color as "draft" in the status column of entry listings)
  • SVG icons in cp widget headers get the same same color as icons in the welcome widget.

Before:
before

After:
after

Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

The status icons are good, but I think the widget icons need to go back the way they were. They were made darker on purpose.

I think the getting started widget icons should be made darker to match instead.

@heidkaemper
Copy link
Contributor Author

Sure, no problem, changes are made.
For my taste, the icons are a little too dark now. Maybe my monitor isn't calibrated properly. :-)

@jasonvarga
Copy link
Member

Thanks!

@jackmcdade jackmcdade merged commit 400dbcc into statamic:5.x Aug 1, 2024
15 checks passed
@dannyuk1982
Copy link

The icons look too dark for me too (Calibrated LG Ultrafine), I can hardly see the darker ones in dark mode.

@jackmcdade
Copy link
Member

The icons look too dark for me too (Calibrated LG Ultrafine), I can hardly see the darker ones in dark mode.

Weird, they look good to me on the same exact monitor. I’ll have another look see.

@dannyuk1982
Copy link

You're vision is likely better than mine, I've got light eyes so pretty light sensitive and also astigmatism, so my eyes aren't too good at seeing subtle contrast differences on dark backgrounds, especially on backlit screens

@jackmcdade
Copy link
Member

Well let's make it work for everyone : D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants