Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Add dark mode to saving overlay on ChangePassword component #10473

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

martyf
Copy link
Contributor

@martyf martyf commented Jul 18, 2024

The saving overlay that is used on the change password popover does not support dark mode:
image

This PR resolves this by doing two things:

  1. removes the white colour from the .saving-overlay class, and
  2. replaces it with Tailwind colours in the ChangePassword.vue to make it easier to work with the dark mode selector.

I believe this is the only piece of code that uses the .saving-overlay class.

Result:
image

This is using dark:bg-dark-600, but dark:bg-dark-800 isn't too bad either.

@duncanmcclean
Copy link
Member

Oh, nice! 💅

Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I tweaked it to just keep it in css. I know we only use the class in one place at the moment, but if we wanted to use it somewhere else we wouldn't have to apply extra styling classes to it.

@jasonvarga jasonvarga merged commit ff00f74 into statamic:5.x Jul 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants