[5.x] Handle required fields when adding entries to nav
#10468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
requested changes
Jul 17, 2024
Returning `null` seems to cause an issue with the `<relationship-input>` component, where as returning nothing or undefined seems to work fine.
Returning `null` seems to cause an issue with the `<relationship-input>` component, where as returning nothing or undefined seems to work fine.
… of github.com:statamic/cms into handle-required-validation-when-adding-entries-to-navs
Good catch, should be sorted now! |
jasonvarga
requested changes
Jul 18, 2024
jasonvarga
deleted the
handle-required-validation-when-adding-entries-to-navs
branch
|
So much stuff being tackled and added all the time. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes some improvements around the handling of required fields in Navigation blueprints.
Currently, when you select entries to add to a navigation, you'll be able to get away without filling any required fields.
With this PR, you'll only be able to select a single entry at a time. After selecting, you'll be taken to the "Edit Page" stack where you'll be able to fill the required field.
Fixes #4582.