[5.x] Warm structure trees during static warm #10412
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue where if you run
static:warm
immediately after a cache clear, entries from a structured collection will 404.This is because mid-query for entries, the
uri
indexes get built (as expected) but for structured entries their uris come from their structures. As part of that, the trees are validated, which also queries the same entries, which don't have uri yet. The uris get indexed as nulls, and therefore will 404 when they are searched for later.Or, something close to that. 😅
This PR is really a workaround, but seems to resolve it.
If you were to run
stache:warm
beforestatic:warm
, or if you visited any pages before runningstatic:warm
, you wouldn't have this issue.