Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Warm structure trees during static warm #10412

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

jasonvarga
Copy link
Member

There's an issue where if you run static:warm immediately after a cache clear, entries from a structured collection will 404.

This is because mid-query for entries, the uri indexes get built (as expected) but for structured entries their uris come from their structures. As part of that, the trees are validated, which also queries the same entries, which don't have uri yet. The uris get indexed as nulls, and therefore will 404 when they are searched for later.

Or, something close to that. 😅

This PR is really a workaround, but seems to resolve it.

If you were to run stache:warm before static:warm, or if you visited any pages before running static:warm, you wouldn't have this issue.

@robdekort
Copy link
Contributor

robdekort commented Jul 8, 2024

This really sounds like it fixes the issue Lars describes in #10410. Or at least what I've noticed happing.

@jasonvarga
Copy link
Member Author

Sounds like it, but this PR is only concerned with static caching. #10410 isn't. 🤔

@robdekort
Copy link
Contributor

Yeah true, I think Lars and I are running into separate issues then. Cuz in my case I def. used full static caching.

@jasonvarga jasonvarga merged commit e6e382a into 5.x Jul 12, 2024
18 checks passed
@jasonvarga jasonvarga deleted the static-warm-structures branch July 12, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants