Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Fix error toast when logging in. #10308

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

jelleroorda
Copy link
Contributor

Fixes #9132.

Thanks @rrelmy for debugging it!

@duncanmcclean
Copy link
Member

Thanks for this pull request! This toast has been driving me mad for months 😅

Go to login page
Click «Forgot password»
Click «I remember my password» to go back to login
Enter correct credentials

While this PR does fix the first variant identified in the comment on the related issue, it doesn't fix this second variant, where you login after visiting the password reset page. 🤔

@jelleroorda
Copy link
Contributor Author

Hmm yea right. I guess we’ll have to single out all “authentication routes?” Or do you have a better suggestion?

@jasonvarga
Copy link
Member

Sorry for the delay. Thanks everyone involved in figuring this out!

@jasonvarga jasonvarga merged commit 5be9c50 into statamic:5.x Aug 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"You cant do this while logged in" toast after logging in
3 participants