Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to_f32() visiblity #7

Closed
PSeitz opened this issue Mar 13, 2018 · 2 comments
Closed

to_f32() visiblity #7

PSeitz opened this issue Mar 13, 2018 · 2 comments

Comments

@PSeitz
Copy link
Contributor

PSeitz commented Mar 13, 2018

Is there a reason why to_f32() is private?
@tspiteri
Copy link
Contributor

Isn't the implementation of From<f16> for f32 enough?

@PSeitz
Copy link
Contributor Author

PSeitz commented Mar 16, 2018

Maybe just personal preference, but I think it's more concise. This is also the interface of rusts num traits (https://rust-num.github.io/num/num_traits/cast/trait.ToPrimitive.html)

@PSeitz PSeitz mentioned this issue Mar 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PSeitz @tspiteri