Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible inconsistent CQL Identifier to string in ListTables and Metadata commands #1587

Open
amorton opened this issue Oct 22, 2024 · 2 comments
Assignees

Comments

@amorton
Copy link
Contributor

amorton commented Oct 22, 2024

The following was added to the CqlIdentifierUtil class

  /** Remove the quotes from the identifier */
  public static String externalRepresentation(CqlIdentifier identifier) {
    return identifier.asInternal();
  }

But we already have

  public static String cqlIdentifierToStringForUser(CqlIdentifier identifier) {
    return identifier.asCql(true);
  }

Why do we want to remove the double quotes ? And if we added this function did we consider removing the other one ?

@amorton
Copy link
Contributor Author

amorton commented Oct 22, 2024

If we do need both, i.e. one way for messages and one for JSON fields names, then we should improve the method names to make it clearer

@amorton
Copy link
Contributor Author

amorton commented Oct 22, 2024

Suggestion from chat with @tatu-at-datastax for name such as

toCql
toJSON
toMessage

fromJSON
fromCQL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants