Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest V3 #106

Open
Kshitiz-Mhto opened this issue Jan 29, 2023 · 7 comments · May be fixed by #117
Open

Manifest V3 #106

Kshitiz-Mhto opened this issue Jan 29, 2023 · 7 comments · May be fixed by #117

Comments

@Kshitiz-Mhto
Copy link

Is there any plan for migrating from Manifest V2 to Manifest V3 soon for Google Chrome Extension.
Manifest version 2 is deprecated, and support will be removed in 2023 such message is showing up while i am trying to load manifest file in my Chrome.

The transition of Chrome extensions to Manifest V3 blog,

for more detail About Manifest V3 timeline

Manifest V2 support timeline

@fahad-israr
Copy link
Collaborator

fahad-israr commented Jan 29, 2023

Should do this. Need to fix automatic release pipeline for chrome first.
Also what about Firfox compatibility with v3?

@Kshitiz-Mhto
Copy link
Author

Kshitiz-Mhto commented Jan 29, 2023

Hi @fahad-israr @maxandersen i tried some changes in manifest and try to migrate from V2 to V3 using Mozilla migration for manifest Doc . I tested on my local machine, it didnot show error in both chrome and firefox.

But, in firefox,
the The developer preview of Manifest V3 is available after Firefox 101. Generally, it is not available for older versions, But can be done by turning on MV3 features, ie.

    Set extensions.manifestV3.enabled to true
    Set xpinstall.signatures.required to false

By default, these were true in my firefox.
Steps to turn on MV3 feature

type about:config in firefox search bar and search the above mentioned options.


In case of Chrome, Every thing went good 👍

Changes i made:
manifest

@fahad-israr
Copy link
Collaborator

assume you are the end user and you install it from the chrome/firefox extension store, would everything work fine ?
also please raise a pr for the changes you've done.

@Kshitiz-Mhto Kshitiz-Mhto linked a pull request Feb 6, 2023 that will close this issue
@Kshitiz-Mhto
Copy link
Author

Kshitiz-Mhto commented Feb 6, 2023

assume you are the end user and you install it from the chrome/firefox extension store, would everything work fine ? also please raise a pr for the changes you've done.

i have tested by loading files on Chrome, it went all good. but in firefox , it is not working as expected.

@Kshitiz-Mhto
Copy link
Author

In firefox, it is not able to provide href attribute to <a> tag as shown in figure:

bottomInspect


as it should provide according to line 32 in context.js
content

@fahad-israr
Copy link
Collaborator

try if you can look for a workaround. Or else a meachnism to upgrade to V3 atleast for Chrome. Also, what version of chrome did you test it upon ? most people would already be upon chrome version released in last 6 months. would find very very few users using versions older than that ig.

@Kshitiz-Mhto
Copy link
Author

Kshitiz-Mhto commented Feb 7, 2023

I tested on Chrome, It worked as expected. I am still experimenting to make it work in firefox also.
chrome version 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 Chrome/109.0.0.0 Safari/537.36'
firefox version "Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/109.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants