Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P1] Location of code for "LM training and serving with ReFT" #71

Open
RonanKMcGovern opened this issue Apr 29, 2024 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@RonanKMcGovern
Copy link

The ReadMe mentions the ability to serve at scale with continuous batching.

Even if not vLLM or TGI, is there some work that someone could point me to on this?

Is there any functioning packaging for serving continuous batching via an endpoint? Thanks

@frankaging frankaging changed the title Location of code for "LM training and serving with ReFT" [P1] Location of code for "LM training and serving with ReFT" Apr 29, 2024
@frankaging frankaging added enhancement New feature or request engineering labels Apr 29, 2024
@frankaging
Copy link
Collaborator

@RonanKMcGovern Thanks for the note! The continuous batching is still in planning right now, we might do it soon (after our conf submission deadline).

I am thinking to implement it not as a generic API, but a pyreft feature where intervention locations on KV cache requires some special handlings (since inputs are concatenated together in that case)

@RonanKMcGovern
Copy link
Author

Noted with thanks @frankaging .

Yes, I was thinking that there'll need to be a separate "inputs" field for the intervention.

This may be a bit wild of an idea, but I wonder if the interventions could be input as images are in vLLM and TGI. It's a case where there needs to be a second "pre-processor".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants