[P0] reft_model loading as reft_model not as pyvene object

[XiaoshuangJi]

A reft_model got by the method get_reft_model() is an instance of ReftModel and we can call the method print_trainable_parameters() to show the number of parameters. However, a reft_model loaded by the method ReftModel.load() is an instance of intervenable_base.IntervenableModel and we can not call the method print_trainable_parameters(). Is this
reasonable?

[frankaging]

@Jixs0528 good catch! this should be fixed!

assigning as a bug with P0. we should prioritize this. @PinetreePantry do you want to take a look?

[PinetreePantry]

@frankaging cool let me take a look

[frankaging]

Fixed! closing this for now. Feel free to reopen if other issues arise. Ty for raising this again.

[frankaging]

hey @Jixs0528 can you provide the error log? NoreftIntervention runs fine on my end.

[frankaging]

providing more evidence here. the weight matrix in NoreftIntervention is initialized with (model_dim, low_rank_dim). the weight matrix is in a shape of (low_rank_dim*model_dim).