Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code not functional #18

Closed
qt1 opened this issue Dec 27, 2020 · 2 comments · May be fixed by #20
Closed

Code not functional #18

qt1 opened this issue Dec 27, 2020 · 2 comments · May be fixed by #20

Comments

@qt1
Copy link

qt1 commented Dec 27, 2020

Some mathematicians purists could argue that the code in not functional!

There are many animations that can (and should) be expressed as a function of 4d space+time.
Thus colors of pixels are just a samples of this function at the LED coordinate t the time of the animation c_i = f(X_i).
@qt1 qt1 mentioned this issue Dec 27, 2020
Open
@oliverdunk
Copy link
Member

Hey @qt1! I agree that the lack of dimensions reflects poorly on someone with a book on the matter. It's a real crisis and something we need to resolve!

That said, Matt asked me to help with the maintenance of this repository, and I think as part of that I should probably close this one out. Sorry for being a grinch 😬

Your PR looks awesome! I'm figuring out how best to handle those and will comment on it soon.

@qt1
Copy link
Author

qt1 commented Jan 18, 2021

Hi @oliverdunk , I just discovered Matt's video with the code running. Thanks for your contribution!

If you need anything now or in future, I'll be happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Functional animation qt1/xmastree2020
2 participants
@oliverdunk @qt1