-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to handle discrete parameters? #17
Comments
I agree but how would their treatment be different? |
You cant use mean, rhat or sd for example. We would probably need to define ordered and non-ordered representations. I actually dont know how to summarize them in a good way? |
I see. At least anything that has more than 2 unordered values will be a problem. For ordered ones, median etc. would still be useful. I agree this is something worth considering and it certainly requires some thought of how to do this correctly. |
Indeed. I guess that we may be a little blind by the stan limitations here. I think a posterior package should at least don't break using discrete parameters. |
Does anybody know how other packages handle those? |
I do not know. I know JAGS has discrete parameters. |
@MansMeg Thanks for raising this issue. This is definitely something we should think about. Maybe the easiest thing to do for now is to just to include discrete parameters like all others but print a message if we detect a discrete parameter that certain summaries/diagnostics do not apply? I'm certainly open to other options though! |
Some thoughts here:
If we wanted to support factors life can get complicated for some formats: e.g., I think matrices of factors break in some corner cases. Other formats, like lists and tibbles, should be fine. As I've been experimenting with So I guess one question is, do we want to support something (e.g. samples of factors) that can only really be represented in some formats and not others? |
I think supporting importants things only in certain formats is fine, and I would consider discrete variables to be one of those important things. We need to find an efficient way to detect their presense and then throw an error if an attempt is made to convert to a format which doesn't support them, but that should be no problem. |
Im not sure if you have discussed this before? I guess it is important to handle since many non-stan models may have discrete parameters.
The text was updated successfully, but these errors were encountered: