🐛: jmap: should not return invalidProperties if Email/set doesn't change anything

[liubog2008]

What happened?

I found that if I set $seen again the server will return an invalidProperities because of no changes. I'm not sure whether it's reasonable.

https://jmap.io/spec-core.html#set says

The SetError object SHOULD also have a property called properties of type String[] that lists all the properties that were invalid.

But there is no properties changed.

How about returning no error and making Email/set idempotent?

How can we reproduce the problem?

I can reproduce the problem by doing the following steps:

Email/set keywords/$seen: true again for an email which has been marked as seen.

Version

v0.11.x

What database are you using?

None

What blob storage are you using?

None

Where is your directory located?

None

What operating system are you using?

None

Relevant log output

Code of Conduct

• I agree to follow this project's Code of Conduct

[mrwogu]

Same here. Flagged as seen randomly returns to unseen after fetch from imap. v0.11.4

LOGS:

2025-02-04T11:38:12Z TRACE Raw IMAP input received (imap.raw-input) listenerId = "imaptls", localPort = 993, remoteIp = xxx.xxx.xxx.xxx, remotePort = 10568, size = 2, contents = "\r\n"
2025-02-04T11:38:12Z TRACE Raw IMAP input received (imap.raw-input) listenerId = "imaptls", localPort = 993, remoteIp = xxx.xxx.xxx.xxx, remotePort = 10568, size = 34, contents = "86 uid store 2153 +Flags (\\Seen)\r\n"
2025-02-04T11:38:12Z DEBUG IMAP error occurred (imap.error) listenerId = "imaptls", localPort = 993, remoteIp = xxx.xxx.xxx.xxx, remotePort = 10568, details = "Unsupported message data item name: "+Flags"", id = "86", type = BAD
2025-02-04T11:38:12Z TRACE Raw IMAP output sent (imap.raw-output) listenerId = "imaptls", localPort = 993, remoteIp = xxx.xxx.xxx.xxx, remotePort = 10568, size = 53, contents = "86 BAD Unsupported message data item name: "+Flags"\r\n"