Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate signer sortition state tracking into the signer binary #4880

Closed
kantai opened this issue Jun 11, 2024 · 0 comments
Closed

Integrate signer sortition state tracking into the signer binary #4880

kantai opened this issue Jun 11, 2024 · 0 comments

Comments

@kantai
Copy link
Member

kantai commented Jun 11, 2024

Signer sortition state tracking was implemented in:

#4801

But it wasn't integrated into the signer binary yet.

The signer runloop should integrate this by holding a SortitionsView option in the RunLoop struct. Integration should be fairly straight forward -- I think roughly:

  1. Add the sortition_state: Option<SortitionsView> field to RunLoop
  2. On receiving a block proposal, if sortitions_view is None, reload it via fetch_view(). Then invoke check_proposal (in addition to the existing checks).
  3. On receiving a burn block event, set sortitions_view to None.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Status: ✅ Done
Development

No branches or pull requests

3 participants