Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nakamoto] PoX reward set state should include the signing key, not the stacker state #4274

Closed
Tracked by #1614
jcnelson opened this issue Jan 22, 2024 · 3 comments
Closed
Tracked by #1614
Assignees
Labels

Comments

@jcnelson
Copy link
Member

The PoX reward set maps need to track the signing key.

@setzeus
Copy link
Collaborator

setzeus commented Jan 24, 2024

Confirming that this means we should remove the existing field from 'stacking-state' which actually has a neat secondary effect: instead of setting the signing-key per-member using 'delegate-stack-stx' the pool operator can now provide a single signing-key w/ 'aggregate-commit-index.'

This is useful since currently a pool operator rotating signing-keys (for some grief reason) midway through stacker sign-ups would cause members already stacked w/ the old key to miss the next cycle.

@setzeus
Copy link
Collaborator

setzeus commented Jan 24, 2024

Discussed & assigned to WIP in #4263.

@MarvinJanssen
Copy link
Member

This was addressed in #4263 and #4269.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

4 participants