-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add burn ops RPC for PegOut #3553
Comments
@igorsyl the PR that added this RPC has been merged. Is that enough to close this one or do we need some additional testing? I've been unable to find any tests that go through the API to make sure new RPCs are exposed. I suppose adding such a test for this PR is not needed then. |
@stjepangolemac please use this PR as a reference to add tests to core-eng for RPC for Peg Out burn ops. You can create a new PR and attach to this issue. Thanks! |
We might not be referring to the same thing but I believe we've already added tests such as those from the linked PR. They've all been moved to this new file: Are those tests the ones you were looking for? |
@kantai is this properly tested? |
Yes, it is. Those tests are fixture/test-vector style tests which assert that the RPC formatting is correct, and then there's assertions in https://github.com/stacks-network/stacks-blockchain/blob/next/testnet/stacks-node/src/tests/neon_integrations.rs#L11103 that check the integration with the rest of the node. |
Refer to PegIn #3511
The text was updated successfully, but these errors were encountered: