Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add burn ops RPC for PegOut #3553

Closed
igorsyl opened this issue Feb 6, 2023 · 5 comments · Fixed by #3577
Closed

Add burn ops RPC for PegOut #3553

igorsyl opened this issue Feb 6, 2023 · 5 comments · Fixed by #3577
Assignees
Labels

Comments

@igorsyl
Copy link
Contributor

igorsyl commented Feb 6, 2023

Refer to PegIn #3511

@stjepangolemac
Copy link
Contributor

@igorsyl the PR that added this RPC has been merged. Is that enough to close this one or do we need some additional testing?

I've been unable to find any tests that go through the API to make sure new RPCs are exposed. I suppose adding such a test for this PR is not needed then.

@igorsyl
Copy link
Contributor Author

igorsyl commented Feb 26, 2023

@stjepangolemac please use this PR as a reference to add tests to core-eng for RPC for Peg Out burn ops. You can create a new PR and attach to this issue. Thanks!
#3511

@stjepangolemac
Copy link
Contributor

We might not be referring to the same thing but I believe we've already added tests such as those from the linked PR.

They've all been moved to this new file:
https://github.com/stacks-network/stacks-blockchain/blob/next/src/chainstate/burn/operations/test/serialization.rs#L430

Are those tests the ones you were looking for?

@igorsyl igorsyl assigned kantai and unassigned kantai Mar 1, 2023
@igorsyl
Copy link
Contributor Author

igorsyl commented Mar 1, 2023

We might not be referring to the same thing but I believe we've already added tests such as those from the linked PR.

They've all been moved to this new file: https://github.com/stacks-network/stacks-blockchain/blob/next/src/chainstate/burn/operations/test/serialization.rs#L430

Are those tests the ones you were looking for?

@kantai is this properly tested?

@kantai
Copy link
Member

kantai commented Mar 1, 2023

Yes, it is. Those tests are fixture/test-vector style tests which assert that the RPC formatting is correct, and then there's assertions in https://github.com/stacks-network/stacks-blockchain/blob/next/testnet/stacks-node/src/tests/neon_integrations.rs#L11103 that check the integration with the rest of the node.

@igorsyl igorsyl closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants