Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stacks-2.1] Can stack-aggregation-commit lock smaller amounts of STX after the minimum threshold for a PoX address has been met? #3360

Closed
jcnelson opened this issue Oct 28, 2022 · 3 comments · Fixed by #3383
Assignees
Labels
locked ship now This is a blocker for the next release (either non-breaking or breaking change) stacks-2.1

Comments

@jcnelson
Copy link
Member

This was a question raised by @friedger on his review of SIP-015. If possible, stack-aggregation-commit should be modified in .pox-2 to permit locking up additional STX for a PoX address once the minimum STX threshold has been met. If this can be done, then new pool members can be added over a sequence of stack-aggregation-commit calls even if their collective STX do not exceed the stacking minimum.

It doesn't look like a very big change in the .pox-2 code; the bulk of this task is in devising an adequate test for it.

@jcnelson
Copy link
Member Author

To speak to the implementation a bit more, the code needs to ensure that the PoX address receiving the STX already has the minimum Stacking threshold, and has an entry in reward-cycle-pox-address-list whose stacker is none. If so, then it needs to add the STX to this already-present entry. It cannot just append a new PoX address with append-reward-cycle-pox-addr, since that would open a DDoS vector -- someone could just stack 1 uSTX a bunch of times in order to grow the reward-cycle-pox-address-list map to contain so many entries that creating a new reward set takes more than the block time.

@jcnelson jcnelson added the ship now This is a blocker for the next release (either non-breaking or breaking change) label Nov 7, 2022
@diwakergupta diwakergupta linked a pull request Nov 8, 2022 that will close this issue
@jcnelson
Copy link
Member Author

Merged!

@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked ship now This is a blocker for the next release (either non-breaking or breaking change) stacks-2.1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants