Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore]: Block Notifier - Include Integration test in CI #220

Open
8marz8 opened this issue May 31, 2024 · 0 comments
Open

[Chore]: Block Notifier - Include Integration test in CI #220

8marz8 opened this issue May 31, 2024 · 0 comments
Labels
sbtc bootstrap signer The sBTC Bootstrap Signer.

Comments

@8marz8
Copy link
Contributor

8marz8 commented May 31, 2024

The block-notifier integration test is currently ignored for the CI to pass.
We need to fix docker-compose.test.yml setup so bitcoin and bitcoind use different RPC ports for all tests to pass. Currently, this test passes locally by running /devenv/local/docker-compose/up.sh to bring up bitcoin and electrs
containers.

If bitcoind can substitute bitcoin container for running electrs, that would resolve port conflict issue.
@netrome netrome added the sbtc bootstrap signer The sBTC Bootstrap Signer. label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sbtc bootstrap signer The sBTC Bootstrap Signer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@netrome @8marz8