Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add value to ShortReturnType runtime error #385

Open
csgui opened this issue Apr 17, 2024 · 0 comments
Open

add value to ShortReturnType runtime error #385

csgui opened this issue Apr 17, 2024 · 0 comments
Assignees
@csgui
Labels
bug Something isn't working
Milestone
WASM Testnet Preview

Comments

@csgui
Copy link
Collaborator

csgui commented Apr 17, 2024 •
edited
Loading

Runtime error ShortReturnType should return the thrown value.

Also related to this issue, the ShortReturnType should be handled accordingly to https://github.com/stacks-network/stacks-core/blob/master/clarity/src/vm/errors.rs#L109. Currently, only AssertionFailed variant is being considered. We also need to handle ExpectedValue variant. Check the return_early implementation for more context.
@csgui csgui added the bug Something isn't working label Apr 17, 2024
@csgui csgui added this to the WASM Phase 1 milestone Apr 17, 2024
@smcclellan smcclellan assigned csgui and unassigned csgui Apr 18, 2024
@csgui csgui mentioned this issue Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csgui csgui

Labels
bug Something isn't working
Projects
Stacks Core Eng
Status: Status: 📋 Backlog
Milestone
WASM Testnet Preview
Development

No branches or pull requests
1 participant
@csgui