Error in as-max-len?

[obycode]

(as-max-len? "" u0)

This is returning none but it should return (some ""). This seems to be a generic issue with as-max-len?.

[obycode]

Experimenting with this a bit more, it seems to be an off by one error. If the length passed to as-max-len? is equal to the length of the value, it should return some value, but it is returning none. If it is length + 1, then it seems fine. It looks like my tests didn't cover that case.

[obycode]

    #[test]
    fn as_max_len_string_utf8() {
        crosscheck(
            r#"(as-max-len? u"hello" u16)"#,
            Ok(Some(
                Value::some(
                    Value::string_utf8_from_string_utf8_literal("hello".to_owned()).unwrap(),
                )
                .unwrap(),
            )),
        );
    }

    #[test]
    fn as_max_len_list() {
        crosscheck(
            r#"(as-max-len? (list 42 21) u2)"#,
            Ok(Some(
                Value::some(
                    Value::cons_list_unsanitized(vec![Value::Int(42), Value::Int(21)]).unwrap(),
                )
                .unwrap(),
            )),
        );
    }

    #[test]
    fn as_max_len_string_0() {
        crosscheck(
            r#"(as-max-len? "" u0)"#,
            Ok(Some(
                Value::some(Value::string_ascii_from_bytes(vec![]).unwrap()).unwrap(),
            )),
        );
    }

    #[test]
    fn as_max_len_list_0() {
        crosscheck(
            r#"(as-max-len? (list) u0)"#,
            Ok(Some(
                Value::some(Value::cons_list_unsanitized(vec![]).unwrap()).unwrap(),
            )),
        );
    }

[obycode]

Fixed in #306