Skip to content

Conversation

@vicentepinto98
Copy link
Contributor

@vicentepinto98 vicentepinto98 commented Mar 19, 2024

With the migration to the stackit-api repo, the generated OAS for global APIs will have a different server url that follows this pattern:

"servers": [
    {
      "url": "https://identifier.api.stackit.cloud",
      "variables": {
        "region": {
          "default": "global"
        }
      }
    }
  ]

This PR updates the ConfigureRegion method to take into account this change

Copy link
Contributor

@joaopalet joaopalet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So for regional APIs the URL will still contain the template, right?

@vicentepinto98
Copy link
Contributor Author

So for regional APIs the URL will still contain the template, right?

Yes, that way we can configure multiple regions, as long as they are defined in the OAS

@vicentepinto98 vicentepinto98 merged commit 82dc248 into main Mar 20, 2024
@vicentepinto98 vicentepinto98 deleted the vp/configure-region-core branch March 20, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants