Skip to content

Fix key flow bugs #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2024
Merged

Fix key flow bugs #334

merged 2 commits into from
Feb 23, 2024

Conversation

@hcsa73
Copy link
Contributor

@hcsa73 hcsa73 commented Feb 22, 2024 •
edited
Loading

  • Fix GetAccessToken() not returning a refreshed token after recreating it
  • Fix service account request using refresh token (grant type set as refresh_token) not setting the refresh token in the expected field
  • Fix parseTokenResponse() returning an unrelated error
  • Fix token expired check failing when token wasn't set
  • Fix continuous refresh token routine failing when access token or refresh token weren't set
  • Fix continuous refresh token routine doing an unsafe read to access token
  • Add checks to TestContinuousRefreshTokenConcurrency when mocking token refresh

hcsa73
hcsa73 commented Feb 22, 2024
View reviewed changes
joaopalet
joaopalet approved these changes Feb 23, 2024
View reviewed changes
@hcsa73 hcsa73 merged commit 2c9d71f into main Feb 23, 2024
@hcsa73 hcsa73 deleted the hs/fix/key-flow branch February 23, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@joaopalet joaopalet joaopalet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hcsa73 @joaopalet