-
Notifications
You must be signed in to change notification settings - Fork 30
fix(dns): print valid JSON/YAML output for list cmds #1040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
relates to STACKITCLI-266 / #893
2238a6d to
947eb73
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Description
relates to STACKITCLI-266 / #893
Testing
stackit dns zone list-> Expected output:No zones found for project "xxx" matching the criteriastackit dns zone list --output-format json-> expected valid JSON outputstackit dns zone list --output-format yaml-> expected valid YAML outputstackit dns zone create --name my-zone --dns-name www.my-zone.comexport ZONE_ID="xxx"stackit dns zone list-> Expected output: Table showing the available DNS zonesstackit dns zone list --output-format json-> expected valid JSON outputstackit dns zone list --output-format yaml-> expected valid YAML outputstackit dns record-set list --zone-id $ZONE_ID-> Expected output: Table showing the default DNS zone record setsstackit dns record-set list --zone-id $ZONE_ID --output-format json-> expected valid JSON outputstackit dns record-set list --zone-id $ZONE_ID --output-format yaml-> expected valid YAML outputstackit dns zone delete $ZONE_IDChecklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)