Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewports lesson #55

Open
jbgitto opened this issue Jan 3, 2015 · 1 comment
Open

Viewports lesson #55

jbgitto opened this issue Jan 3, 2015 · 1 comment

Comments

@jbgitto
Copy link

jbgitto commented Jan 3, 2015

Hi,

Great course, enjoying it :)

Sorry if I am missing something but it appears that the top and left parameters described in the viewport function for the viewports lesson are the wrong way around.

The lesson describes the parameters as
gl.viewport(top, left, width, height)

The spec describes it as gl.viewport(x, y, width, height)

If the correct parameter order were gl.viewport(top, left, width, height) as described in the lesson then the solution would be gl.viewport(0, width/2, width/2, height) and not the accepted (and working) solution of gl.viewport(width/2, 0, width/2, height) to draw the bunny on the right hand side of the screen.

The parameters should be described as gl.viewport(left, top, width, height) in the lesson.

@Trott
Copy link

Trott commented Mar 3, 2015

Looks like this is fixed in the master branch. It just hasn't been published to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants