Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add onStop callback to SpotLightTourProvider props #90

Merged
merged 6 commits into from
May 29, 2023

Conversation

alejo0o
Copy link
Contributor

@alejo0o alejo0o commented Apr 12, 2023

This PR adds the possibility to run some events or actions after the tour stops by adding a new prop to the SpotLightTourProvider called onStop.
It solves issue #89

@alejo0o alejo0o requested a review from JoseLion April 12, 2023 19:32
@alejo0o alejo0o self-assigned this Apr 12, 2023
@alejo0o alejo0o added the enhancement New feature or request label Apr 12, 2023
@JoseLion JoseLion changed the title Add onStop prop to SpotLightTourProvider to run actions after the tou… feat(core): Add onStop callback to SpotLightTourProvider props Apr 13, 2023
Copy link
Member

@JoseLion JoseLion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @alejo0o! I left a minor suggestion, but I think this one's ready to merge. Thanks! 🎉

PS: Nice testing! Clear and concise 🙂

package/src/lib/SpotlightTour.provider.tsx Outdated Show resolved Hide resolved
package/src/lib/SpotlightTour.context.ts Outdated Show resolved Hide resolved
package/src/lib/SpotlightTour.provider.tsx Outdated Show resolved Hide resolved
@alejo0o alejo0o merged commit adbc23f into main May 29, 2023
@JoseLion JoseLion deleted the feat/onStop-actions branch June 12, 2023 15:52
@JoseLion
Copy link
Member

@all-contributors please add @alejo0o for code

@allcontributors
Copy link
Contributor

@JoseLion

I've put up a pull request to add @alejo0o! 🎉

@github-actions
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants