Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NaN Causes app to crash #147

Open
rililive opened this issue Jun 27, 2024 · 6 comments
Open

NaN Causes app to crash #147

rililive opened this issue Jun 27, 2024 · 6 comments

Comments

@rililive
Copy link

I'm getting this error where the attempt to place the tour modal returns NaN for the left positioning. I'm working on ios with [email protected]

Screenshot 2024-06-27 at 12 28 50 PM
@rililive
Copy link
Author

@tragicmj
Copy link

tragicmj commented Aug 9, 2024

I am facing the same issue, did anyone found any fix. The solution is mentioned in the above comment is a bit complex

@thonyromes
Copy link

Same issue on react native 0.75.2 when I wrap my component with a <View />

@Horley123
Copy link

Horley123 commented Sep 18, 2024

I have this same problem in react native 0.75.2 only on ios

@thonyromes
Copy link

thonyromes commented Sep 18, 2024

Here is a very temporary fix, please switch back once a new version is out 🙏.

I noticed when I forked the current main, the issue seems to have been fixed.

Although, I also added a hook useSpotlightStep you can use directly to create a custom AttachStep wrapper and also a SpotlightStep with slightly different implementation.

Add this to your package.json. I forked the current main, then created a new repo just for the package.
"react-native-spotlight-tour": "github:thonyromes/react-native-spotlight-tour-nativewind",

@Horley123
Copy link

Obrigado @thonyromes, funcionou aqui pra min.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants