Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install dependencies into node_modules, not turbo_modules #333

Closed
justinfagnani opened this issue Mar 13, 2018 · 8 comments
Closed

Install dependencies into node_modules, not turbo_modules #333

justinfagnani opened this issue Mar 13, 2018 · 8 comments

Comments

@justinfagnani
Copy link

It's very unintuitive that dependencies are installed into turbo_modules. It took a while to even figure that out.

@EricSimons
Copy link
Member

How are you seeing this? From error stacktraces? Was meant to be an under-the-hood sort of thing for us, but understand why it's confusing if it bubbles up to the user

@justinfagnani
Copy link
Author

You need to reference files from packages sometimes. See https://stackblitz.com/edit/js-whexau?file=index.html

@justinfagnani
Copy link
Author

HTML and CSS (and JS really) can't use package names to reference resource. There are a number of cases where this comes up: <link preload/modulepreload/stylesheet>, CSS url() and @import, and import and dynamic import() if you're using native modules.

@EricSimons
Copy link
Member

@justinfagnani gotchya. StackBlitz was originally designed for projects that are using compilers/loaders/etc, so linking to node_modules in index.html isn't something we originally we planning to support. This is being changed in our bundler upgrade though, so you'll be able to link to node_modules in HTML files.

ETA is end of month/early next 💪

@justinfagnani
Copy link
Author

You rock, thanks for all the improvements!

@Misiu
Copy link

Misiu commented Mar 17, 2018

@EricSimons awesome news!

@benshabatnoam
Copy link

Will we be able to see node_modules files structure? when installing a dependency to node_modules we don't always know the path to the desired file, it would be awesome to see the file structure. Thanks a lot.

@kc0tlh kc0tlh removed the on deck label May 20, 2021
@kc0tlh
Copy link
Collaborator

kc0tlh commented Aug 23, 2023

This feature is now implemented in our new VS Code editor, available here!

@kc0tlh kc0tlh closed this as completed Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants