Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenID Connect support #405

Closed
Tracked by #431 ...
fhennig opened this issue Sep 18, 2023 · 2 comments · Fixed by #423
Closed
Tracked by #431 ...

OpenID Connect support #405

fhennig opened this issue Sep 18, 2023 · 2 comments · Fixed by #423
Assignees
Labels
release/24.3.0 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Comments

@fhennig
Copy link
Contributor

fhennig commented Sep 18, 2023

Out-of-the-box, Superset does not have OpenID Connect (OIDC) support. It does however support OAuth 2.0, and OIDC providers like Keycloak provide OAuth 2.0 support as well, so Superset can be configured to work with that.

Direct support for OIDC would require adding an addtional dependency to the Docker image and modifying some code. the code changes would also be on a security-critical path and we would need to be aware of upstream modifications each update. It would be a difficult route to go down I believe.

useful Stackoverflow question - our docs on the topic

@siegfriedweber siegfriedweber self-assigned this Oct 25, 2023
@siegfriedweber siegfriedweber moved this to Development: In Progress in Stackable Engineering Oct 25, 2023
@siegfriedweber siegfriedweber moved this to Ready for Development in Stackable Engineering Jan 10, 2024
@siegfriedweber siegfriedweber moved this from Ready for Development to Development: In Progress in Stackable Engineering Jan 11, 2024
@siegfriedweber siegfriedweber moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Jan 30, 2024
@razvan razvan moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jan 30, 2024
@siegfriedweber siegfriedweber moved this from Development: In Review to Development: Done in Stackable Engineering Jan 31, 2024
@lfrancke lfrancke added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 1, 2024
@lfrancke
Copy link
Member

lfrancke commented Feb 1, 2024

Does this contain a CRD change? If so: Is it breaking?

@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Feb 1, 2024
@siegfriedweber
Copy link
Member

@lfrancke Yes, there is a CRD change. An oidc property was added to the authentication entries, which is only required if an OIDC AuthenticationClass is provided, see https://docs.stackable.tech/home/nightly/contributor/adr/adr032-oidc-support#_product_cluster_configuration_design. So this change is not breaking.

@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Feb 1, 2024
@lfrancke lfrancke added the release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/24.3.0 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants