Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RELEASE and VERSION labels in product images #152

Open
2 tasks
maltesander opened this issue Jul 13, 2022 · 0 comments
Open
2 tasks

Fix RELEASE and VERSION labels in product images #152

maltesander opened this issue Jul 13, 2022 · 0 comments

Comments

@maltesander
Copy link
Member

Our docker images currently have a hard coded label RELEASE=1 which was required for Openshift certification. Another label is VERSION which currently is set from the product version (e.g. 3.8.0 for a ZooKeeper 3.8.0).

For RELEASE we want to update to our actual naming of our releases. The next one would be 22.09. This should probably be parameterized in the build script instead of each product image.

The version label does not make sense currently. It will always be 3.8.0 (for a ZooKeeper 3.8.0) even if we adapt, add to or change that image.

The VERSION label should become the full tag we create from that image like zookeeper3.8.0-stackable0.1.0 to clearly identify the image.

This is done when:

  • The RELEASE label is set "globally" via a CLI parameter in the build script
  • The VERSION label is set to the actually name of the created docker images like zookeeper3.8.0-stackable0.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant