Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to build without QTextCodec #151

Closed
xlazom00 opened this issue Jul 29, 2022 · 3 comments
Closed

Possibility to build without QTextCodec #151

xlazom00 opened this issue Jul 29, 2022 · 3 comments

Comments

@xlazom00
Copy link

xlazom00 commented Jul 29, 2022

I would like to propose idea that we can build quazip without QTextCodec.

  • with some cmake switch
  • checking qt if qt has QTextCodec support

as in Qt6 QTextCodec is deprecated

And there is also option to add support for QStringDecoder
I found this
QStringDecoder vs QTextCodec

@xlazom00
Copy link
Author

xlazom00 commented Aug 2, 2022

@oblivioncth
Copy link

Qt 6.4 is enabling QStringConverter to use any encoding provided by ICU when Qt is built with ICU support enabled.

https://doc-snapshots.qt.io/qt6-dev/whatsnew64.html
https://doc-snapshots.qt.io/qt6-dev/qstringconverter.html#encodingForName

In the long run this is probably the preferred alternative for handling encodings that were previously deprecated by Qt6, rather than a manual switch like the above (though they can certainly coexist). Build Qt with ICU support, get extended encoding support in QuaZip.

This would allow dropping the Qt5Compat module as a requirement when using Qt6 outright.

@cen1
Copy link
Collaborator

cen1 commented Mar 10, 2024

Closing in favor of a more recent #184

@cen1 cen1 closed this as completed Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants