Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API to add multiple files to same zip. #120

Open
Sourabh-Pandit opened this issue Jun 10, 2021 · 4 comments
Open

API to add multiple files to same zip. #120

Sourabh-Pandit opened this issue Jun 10, 2021 · 4 comments

Comments

@Sourabh-Pandit
Copy link

Sourabh-Pandit commented Jun 10, 2021

As of now we 2 apis to compress the file/s, one compress a single file and other compress list of files. There may be a situation, where in we need to add more files to existing zip file. as of now we dont have any such api to append the existing zip file.
I have added 2 APIs in the JLCompress to address the use case stated here.
But the quick fix would be to open a zipfile with mode QuaZip::mdAdd instead of QuaZip::mdCreate.

Thanks,
S.P

@stachenov
Copy link
Owner

A quick fix is not a very good idea because it's changing behavior of the existing API.

Adding new API is a good idea. Submit a PR if you'd like the fix to be publicly available.

@Sourabh-Pandit
Copy link
Author

Thanks, I will submit a PR

@Neustradamus
Copy link

@Sourabh-Pandit: Have you done a PR?

@Sourabh-Pandit
Copy link
Author

No I couldnt do the PR, had some issue from my side. then I forgot about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants