ProjectionExtension v2 (proj:epsg -> proj:code) #1287

jsignell · 2023-12-04T22:05:06Z

Related Issue(s):

Support for projection v2.0.0 extension #1286

Description:

The intention of this PR is to still support using epsg and just store it in proj:code.

Note

This PR removes epsg as a positional argument to ProjectionExtension.apply. It also removes all positional arguments to it should raise nice errors for that scenario.

Another option would be to allow positional arguments and automatically deduce whether they should be interpreted as epsg or code based on type. I suspect that using epsg as a positional argument in apply is rare, so I strongly prefer the approach in this PR.

TO DO:

get summaries working properly (waiting on Add proj:code stac-fields#27)
remove local override of projection extension (waiting on Adds support for IAU codes. stac-extensions/projection#12)
add explicit tests for old versions of the extension

PR Checklist:

pre-commit hooks pass locally
Tests pass (run scripts/test)
Documentation has been updated to reflect changes, if applicable
This PR maintains or improves overall codebase code coverage.
Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

nick-j-roberts · 2024-10-24T21:21:10Z

Just checking in on this, is there a date by which the change to support proj:code instead of proj:epsg is expected to take effect?

gadomski · 2024-10-24T21:52:37Z

Just checking in on this, is there a date by which the change to support proj:code instead of proj:epsg is expected to take effect?

Not at this time ... always looking for folks to help out to help move things along!

KeynesYouDigIt · 2024-12-31T00:11:53Z

@jsignell I noticed that to fix summaries, I am going to have to edit https://github.com/stac-utils/pystac/blob/main/pystac/static/fields-normalized.json - which is easy enough! but it's not formatted at all as a file, so I wanted to check: is it a build artifact of some other dict or somethinng? or is it just kinda new / should be edited directly if I need to make changes?

Also, whats the best way to run tests with changes to this file? override to a local path or push my local copy to the CDN somehow?

gadomski · 2024-12-31T12:05:24Z

or is it just kinda new / should be edited directly if I need to make changes?

fields-normalized.json is pulled from https://www.npmjs.com/package/@radiantearth/stac-fields via this script.

KeynesYouDigIt · 2024-12-31T16:57:49Z

Right I saw that, and it does make sense, but if I need to change it, do I just Change it like I would than any other file in the repo?

…

On Tue, Dec 31, 2024 at 5:05 AM Pete Gadomski ***@***.***> wrote: or is it just kinda new / should be edited directly if I need to make changes? fields-normalized.json is pulled from ***@***.***/stac-fields via this script <https://github.com/stac-utils/pystac/blob/main/scripts/pull-static>. — Reply to this email directly, view it on GitHub <#1287 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACOH4J2YA47IQCDZZMXISDD2IKCBVAVCNFSM6AAAAABQR6WDL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRWGM4TGMJXGE> . You are receiving this because you commented.Message ID: ***@***.***>

gadomski · 2024-12-31T17:34:42Z

Right I saw that, and it does make sense, but if I need to change it, do I
just Change it like I would than any other file in the repo?

I don't quite understand the question. Any modifications to fields-normalized.json should probably be made via PR on https://github.com/stac-utils/stac-fields, unless it's a PySTAC-specific modification.

KeynesYouDigIt · 2025-01-01T04:50:21Z

Sorry I didn’t get to follow up - After I walked away from my computer, I was wondering if that was what you meant. That answers my question, I’ll probably start with a PR to that repo then! Thanks!

jsignell · 2025-01-02T21:46:29Z

Sorry I didn’t get to follow up - After I walked away from my computer, I was wondering if that was what you meant. That answers my question, I’ll probably start with a PR to that repo then! Thanks!

Hi @KeynesYouDigIt! Thanks for trying to pick this back up. I had opened a PR on stac-fields (stac-utils/stac-fields#27) back when I was working on this, and it looks like that morphed into stac-utils/stac-fields@ebd9c99 is there something more that you need? Or maybe it's just a matter of updating a dependency.

KeynesYouDigIt · 2025-01-06T02:43:26Z

Hi @jsignell !

Or maybe it's just a matter of updating a dependency.

Whoops, yeah thats it.

Shoulda seen that, thanks for the help! Will let you know how it goes, hoping to wrap it up soon.

KeynesYouDigIt · 2025-01-11T21:23:48Z

@jsignell So I have commits on this branch that should cover the step

get summaries working properly

https://github.com/KeynesYouDigIt/pystac/tree/refs/heads/proj-v2
(CI workflow) https://github.com/KeynesYouDigIt/pystac/actions/runs/12727145368

Let me know if I should PR to your branch or directly to this one, I have no preference.

As far as the next step, I'm hunting around for exactly what this means...

remove local override of projection extension

Could you point me to where this is done and what this means? Does this refer to some of the URI constants in pystac/extensions/projection.py or something else? (still getting my head around the extensions stuff)

Also we might add some more unit tests, but what do you think?

pystac/validation/jsonschemas/projection.json

pystac/validation/local_validator.py

codecov · 2025-01-13T19:30:12Z

Codecov Report

Attention: Patch coverage is 79.62963% with 11 lines in your changes missing coverage. Please review.

Project coverage is 91.23%. Comparing base (ab747be) to head (2aad94f).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pystac/extensions/projection.py	81.39%	4 Missing and 4 partials ⚠️
pystac/extensions/eo.py	57.14%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1287      +/-   ##
==========================================
- Coverage   91.32%   91.23%   -0.09%     
==========================================
  Files          53       53              
  Lines        7293     7335      +42     
  Branches      885      894       +9     
==========================================
+ Hits         6660     6692      +32     
- Misses        452      457       +5     
- Partials      181      186       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jsignell · 2025-01-13T19:30:34Z

Ok! @KeynesYouDigIt thanks so much for pushing this forward! I pulled your commits into this branch and did a few tidy ups. It looks like things are passing now, but as you mentioned more unit tests/docs would be super useful!

jsignell · 2025-01-13T19:48:10Z

pystac/extensions/projection.py

-        epsg: int | None,
+        *,
+        epsg: int | None = None,
+        code: str | None = None,


@gadomski if we want strictly no API changes we could take away the no positional args constraint, but I think we'd want to add it in pystac v2 to make the behavior very explicit.

Yeah I think that's fine, might break a few folks but it's an easy fix on their part.

gadomski

Oof, thanks for doing this — PySTAC extensions, huh 😓? Just one or two comments, otherwise looks good.

gadomski · 2025-01-14T16:00:34Z

pystac/extensions/projection.py

-        epsg: int | None,
+        *,
+        epsg: int | None = None,
+        code: str | None = None,


Yeah I think that's fine, might break a few folks but it's an easy fix on their part.

pystac/extensions/projection.py

KeynesYouDigIt · 2025-01-18T20:57:20Z

Great work everybody! CC: @nick-j-roberts

jsignell added 2 commits December 4, 2023 16:54

Update for projection extension v2 (proj:epsg -> proj:code)

839dadd

Merge branch 'main' into proj-v2

af05d17

jsignell mentioned this pull request Dec 11, 2023

Add proj:code to support Projection extension v2 stac-utils/stac-fields#26

Closed

Add tests for old version of the extension

0a51f7a

gadomski mentioned this pull request Dec 19, 2023

Adds support for IAU codes. stac-extensions/projection#12

Merged

jsignell linked an issue Jul 31, 2024 that may be closed by this pull request

Support for projection v2.0.0 extension #1286

Closed

gadomski mentioned this pull request Dec 25, 2024

Support for projection v2.0.0 extension #1286

Closed

KeynesYouDigIt added 3 commits January 11, 2025 12:48

Merge branch 'main' into proj-v2

0cb9163

add new fields config to fix summaries

505dada

precommit touch up

4d65d84

jsignell commented Jan 13, 2025

View reviewed changes

pystac/validation/jsonschemas/projection.json Outdated Show resolved Hide resolved

jsignell commented Jan 13, 2025

View reviewed changes

pystac/validation/local_validator.py Outdated Show resolved Hide resolved

jsignell added 3 commits January 13, 2025 14:23

Merge branch 'main' into proj-v2

212ede0

Rebuild cassettes

8d83953

Tidy up fields - remove dev changes

f40f760

jsignell mentioned this pull request Jan 13, 2025

Proj v2 #1493

Closed

4 tasks

jsignell commented Jan 13, 2025

View reviewed changes

Test errors

461632b

Revert changes to docs notebook

2aad94f

jsignell marked this pull request as ready for review January 13, 2025 19:54

jsignell requested a review from gadomski January 13, 2025 19:54

gadomski reviewed Jan 14, 2025

View reviewed changes

gadomski approved these changes Jan 14, 2025

View reviewed changes

gadomski added this pull request to the merge queue Jan 14, 2025

Merged via the queue into stac-utils:main with commit 2261b55 Jan 14, 2025
23 checks passed

jsignell deleted the proj-v2 branch January 14, 2025 21:57

gadomski mentioned this pull request Jan 17, 2025

Get CRS from proj:code property opendatacube/odc-stac#187

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ProjectionExtension v2 (proj:epsg -> proj:code) #1287

ProjectionExtension v2 (proj:epsg -> proj:code) #1287

jsignell commented Dec 4, 2023 •

edited

Loading

nick-j-roberts commented Oct 24, 2024

gadomski commented Oct 24, 2024

KeynesYouDigIt commented Dec 31, 2024 •

edited

Loading

gadomski commented Dec 31, 2024

KeynesYouDigIt commented Dec 31, 2024 via email

gadomski commented Dec 31, 2024

KeynesYouDigIt commented Jan 1, 2025 via email •

edited

Loading

jsignell commented Jan 2, 2025 •

edited

Loading

KeynesYouDigIt commented Jan 6, 2025 •

edited

Loading

KeynesYouDigIt commented Jan 11, 2025 •

edited

Loading

codecov bot commented Jan 13, 2025 •

edited

Loading

jsignell commented Jan 13, 2025

jsignell Jan 13, 2025

gadomski Jan 14, 2025

gadomski left a comment

gadomski Jan 14, 2025

KeynesYouDigIt commented Jan 18, 2025

ProjectionExtension v2 (proj:epsg -> proj:code) #1287

ProjectionExtension v2 (proj:epsg -> proj:code) #1287

Conversation

jsignell commented Dec 4, 2023 • edited Loading

nick-j-roberts commented Oct 24, 2024

gadomski commented Oct 24, 2024

KeynesYouDigIt commented Dec 31, 2024 • edited Loading

gadomski commented Dec 31, 2024

KeynesYouDigIt commented Dec 31, 2024 via email

gadomski commented Dec 31, 2024

KeynesYouDigIt commented Jan 1, 2025 via email • edited Loading

jsignell commented Jan 2, 2025 • edited Loading

KeynesYouDigIt commented Jan 6, 2025 • edited Loading

KeynesYouDigIt commented Jan 11, 2025 • edited Loading

codecov bot commented Jan 13, 2025 • edited Loading

Codecov Report

jsignell commented Jan 13, 2025

jsignell Jan 13, 2025

Choose a reason for hiding this comment

gadomski Jan 14, 2025

Choose a reason for hiding this comment

gadomski left a comment

Choose a reason for hiding this comment

gadomski Jan 14, 2025

Choose a reason for hiding this comment

KeynesYouDigIt commented Jan 18, 2025

jsignell commented Dec 4, 2023 •

edited

Loading

KeynesYouDigIt commented Dec 31, 2024 •

edited

Loading

KeynesYouDigIt commented Jan 1, 2025 via email •

edited

Loading

jsignell commented Jan 2, 2025 •

edited

Loading

KeynesYouDigIt commented Jan 6, 2025 •

edited

Loading

KeynesYouDigIt commented Jan 11, 2025 •

edited

Loading

codecov bot commented Jan 13, 2025 •

edited

Loading