Skip to content

Commit f172ac5

Browse files
authored
Removes MessageAttribute in favor of properties on Message class (#1270)
* Exludes the test projects from code coverage reports * Removes MessageAttribute in favor of properties on Message class * Benchmark for removal of MessageAttribute
1 parent 6220beb commit f172ac5

File tree

52 files changed

+755
-138
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+755
-138
lines changed

src/Renci.SshNet/Messages/Authentication/BannerMessage.cs

+18-1
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,29 @@
33
/// <summary>
44
/// Represents SSH_MSG_USERAUTH_BANNER message.
55
/// </summary>
6-
[Message("SSH_MSG_USERAUTH_BANNER", 53)]
76
public class BannerMessage : Message
87
{
98
private byte[] _message;
109
private byte[] _language;
1110

11+
/// <inheritdoc />
12+
public override string MessageName
13+
{
14+
get
15+
{
16+
return "SSH_MSG_USERAUTH_BANNER";
17+
}
18+
}
19+
20+
/// <inheritdoc />
21+
public override byte MessageNumber
22+
{
23+
get
24+
{
25+
return 53;
26+
}
27+
}
28+
1229
/// <summary>
1330
/// Gets banner message.
1431
/// </summary>

src/Renci.SshNet/Messages/Authentication/FailureMessage.cs

+18-1
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,26 @@ namespace Renci.SshNet.Messages.Authentication
55
/// <summary>
66
/// Represents SSH_MSG_USERAUTH_FAILURE message.
77
/// </summary>
8-
[Message("SSH_MSG_USERAUTH_FAILURE", 51)]
98
public class FailureMessage : Message
109
{
10+
/// <inheritdoc />
11+
public override string MessageName
12+
{
13+
get
14+
{
15+
return "SSH_MSG_USERAUTH_FAILURE";
16+
}
17+
}
18+
19+
/// <inheritdoc />
20+
public override byte MessageNumber
21+
{
22+
get
23+
{
24+
return 51;
25+
}
26+
}
27+
1128
/// <summary>
1229
/// Gets or sets the allowed authentications if available.
1330
/// </summary>

src/Renci.SshNet/Messages/Authentication/InformationRequestMessage.cs

+18-1
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,26 @@ namespace Renci.SshNet.Messages.Authentication
88
/// <summary>
99
/// Represents SSH_MSG_USERAUTH_INFO_REQUEST message.
1010
/// </summary>
11-
[Message("SSH_MSG_USERAUTH_INFO_REQUEST", 60)]
1211
internal sealed class InformationRequestMessage : Message
1312
{
13+
/// <inheritdoc />
14+
public override string MessageName
15+
{
16+
get
17+
{
18+
return "SSH_MSG_USERAUTH_INFO_REQUEST";
19+
}
20+
}
21+
22+
/// <inheritdoc />
23+
public override byte MessageNumber
24+
{
25+
get
26+
{
27+
return 60;
28+
}
29+
}
30+
1431
/// <summary>
1532
/// Gets information request name.
1633
/// </summary>

src/Renci.SshNet/Messages/Authentication/InformationResponseMessage.cs

+18-1
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,26 @@ namespace Renci.SshNet.Messages.Authentication
66
/// <summary>
77
/// Represents SSH_MSG_USERAUTH_INFO_RESPONSE message.
88
/// </summary>
9-
[Message("SSH_MSG_USERAUTH_INFO_RESPONSE", 61)]
109
internal sealed class InformationResponseMessage : Message
1110
{
11+
/// <inheritdoc />
12+
public override string MessageName
13+
{
14+
get
15+
{
16+
return "SSH_MSG_USERAUTH_INFO_RESPONSE";
17+
}
18+
}
19+
20+
/// <inheritdoc />
21+
public override byte MessageNumber
22+
{
23+
get
24+
{
25+
return 61;
26+
}
27+
}
28+
1229
/// <summary>
1330
/// Gets authentication responses.
1431
/// </summary>

src/Renci.SshNet/Messages/Authentication/PasswordChangeRequiredMessage.cs

+18-1
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,26 @@
33
/// <summary>
44
/// Represents SSH_MSG_USERAUTH_PASSWD_CHANGEREQ message.
55
/// </summary>
6-
[Message("SSH_MSG_USERAUTH_PASSWD_CHANGEREQ", 60)]
76
internal sealed class PasswordChangeRequiredMessage : Message
87
{
8+
/// <inheritdoc />
9+
public override string MessageName
10+
{
11+
get
12+
{
13+
return "SSH_MSG_USERAUTH_PASSWD_CHANGEREQ";
14+
}
15+
}
16+
17+
/// <inheritdoc />
18+
public override byte MessageNumber
19+
{
20+
get
21+
{
22+
return 60;
23+
}
24+
}
25+
926
/// <summary>
1027
/// Gets password change request message as UTF-8 encoded byte array.
1128
/// </summary>

src/Renci.SshNet/Messages/Authentication/PublicKeyMessage.cs

+18-1
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,26 @@
33
/// <summary>
44
/// Represents SSH_MSG_USERAUTH_PK_OK message.
55
/// </summary>
6-
[Message("SSH_MSG_USERAUTH_PK_OK", 60)]
76
internal sealed class PublicKeyMessage : Message
87
{
8+
/// <inheritdoc />
9+
public override string MessageName
10+
{
11+
get
12+
{
13+
return "SSH_MSG_USERAUTH_PK_OK";
14+
}
15+
}
16+
17+
/// <inheritdoc />
18+
public override byte MessageNumber
19+
{
20+
get
21+
{
22+
return 60;
23+
}
24+
}
25+
926
/// <summary>
1027
/// Gets the name of the public key algorithm as ASCII encoded byte array.
1128
/// </summary>

src/Renci.SshNet/Messages/Authentication/RequestMessage.cs

+18-1
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,26 @@ namespace Renci.SshNet.Messages.Authentication
66
/// <summary>
77
/// Represents SSH_MSG_USERAUTH_REQUEST message. Server as a base message for other user authentication requests.
88
/// </summary>
9-
[Message("SSH_MSG_USERAUTH_REQUEST", AuthenticationMessageCode)]
109
public abstract class RequestMessage : Message
1110
{
11+
/// <inheritdoc />
12+
public override string MessageName
13+
{
14+
get
15+
{
16+
return "SSH_MSG_USERAUTH_REQUEST";
17+
}
18+
}
19+
20+
/// <inheritdoc />
21+
public override byte MessageNumber
22+
{
23+
get
24+
{
25+
return AuthenticationMessageCode;
26+
}
27+
}
28+
1229
/// <summary>
1330
/// Returns the authentication message code for <c>SSH_MSG_USERAUTH_REQUEST</c>.
1431
/// </summary>

src/Renci.SshNet/Messages/Authentication/SuccessMessage.cs

+18-1
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,26 @@
33
/// <summary>
44
/// Represents SSH_MSG_USERAUTH_SUCCESS message.
55
/// </summary>
6-
[Message("SSH_MSG_USERAUTH_SUCCESS", 52)]
76
public class SuccessMessage : Message
87
{
8+
/// <inheritdoc />
9+
public override string MessageName
10+
{
11+
get
12+
{
13+
return "SSH_MSG_USERAUTH_SUCCESS";
14+
}
15+
}
16+
17+
/// <inheritdoc />
18+
public override byte MessageNumber
19+
{
20+
get
21+
{
22+
return 52;
23+
}
24+
}
25+
926
/// <summary>
1027
/// Called when type specific data need to be loaded.
1128
/// </summary>

src/Renci.SshNet/Messages/Connection/ChannelCloseMessage.cs

+18-1
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,26 @@
33
/// <summary>
44
/// Represents SSH_MSG_CHANNEL_CLOSE message.
55
/// </summary>
6-
[Message("SSH_MSG_CHANNEL_CLOSE", 97)]
76
public class ChannelCloseMessage : ChannelMessage
87
{
8+
/// <inheritdoc />
9+
public override string MessageName
10+
{
11+
get
12+
{
13+
return "SSH_MSG_CHANNEL_CLOSE";
14+
}
15+
}
16+
17+
/// <inheritdoc />
18+
public override byte MessageNumber
19+
{
20+
get
21+
{
22+
return 97;
23+
}
24+
}
25+
926
/// <summary>
1027
/// Initializes a new instance of the <see cref="ChannelCloseMessage"/> class.
1128
/// </summary>

src/Renci.SshNet/Messages/Connection/ChannelDataMessage.cs

+17-2
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,25 @@ namespace Renci.SshNet.Messages.Connection
55
/// <summary>
66
/// Represents SSH_MSG_CHANNEL_DATA message.
77
/// </summary>
8-
[Message("SSH_MSG_CHANNEL_DATA", MessageNumber)]
98
public class ChannelDataMessage : ChannelMessage
109
{
11-
internal const byte MessageNumber = 94;
10+
/// <inheritdoc />
11+
public override string MessageName
12+
{
13+
get
14+
{
15+
return "SSH_MSG_CHANNEL_DATA";
16+
}
17+
}
18+
19+
/// <inheritdoc />
20+
public override byte MessageNumber
21+
{
22+
get
23+
{
24+
return 94;
25+
}
26+
}
1227

1328
/// <summary>
1429
/// Gets the message data.

src/Renci.SshNet/Messages/Connection/ChannelEofMessage.cs

+18-1
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,26 @@
33
/// <summary>
44
/// Represents SSH_MSG_CHANNEL_EOF message.
55
/// </summary>
6-
[Message("SSH_MSG_CHANNEL_EOF", 96)]
76
public class ChannelEofMessage : ChannelMessage
87
{
8+
/// <inheritdoc />
9+
public override string MessageName
10+
{
11+
get
12+
{
13+
return "SSH_MSG_CHANNEL_EOF";
14+
}
15+
}
16+
17+
/// <inheritdoc />
18+
public override byte MessageNumber
19+
{
20+
get
21+
{
22+
return 96;
23+
}
24+
}
25+
926
/// <summary>
1027
/// Initializes a new instance of the <see cref="ChannelEofMessage"/> class.
1128
/// </summary>

src/Renci.SshNet/Messages/Connection/ChannelExtendedDataMessage.cs

+18-1
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,26 @@
33
/// <summary>
44
/// Represents SSH_MSG_CHANNEL_EXTENDED_DATA message.
55
/// </summary>
6-
[Message("SSH_MSG_CHANNEL_EXTENDED_DATA", 95)]
76
public class ChannelExtendedDataMessage : ChannelMessage
87
{
8+
/// <inheritdoc />
9+
public override string MessageName
10+
{
11+
get
12+
{
13+
return "SSH_MSG_CHANNEL_EXTENDED_DATA";
14+
}
15+
}
16+
17+
/// <inheritdoc />
18+
public override byte MessageNumber
19+
{
20+
get
21+
{
22+
return 95;
23+
}
24+
}
25+
926
/// <summary>
1027
/// Gets message data type code.
1128
/// </summary>

src/Renci.SshNet/Messages/Connection/ChannelFailureMessage.cs

+18-1
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,26 @@
33
/// <summary>
44
/// Represents SSH_MSG_CHANNEL_FAILURE message.
55
/// </summary>
6-
[Message("SSH_MSG_CHANNEL_FAILURE", 100)]
76
public class ChannelFailureMessage : ChannelMessage
87
{
8+
/// <inheritdoc />
9+
public override string MessageName
10+
{
11+
get
12+
{
13+
return "SSH_MSG_CHANNEL_FAILURE";
14+
}
15+
}
16+
17+
/// <inheritdoc />
18+
public override byte MessageNumber
19+
{
20+
get
21+
{
22+
return 100;
23+
}
24+
}
25+
926
/// <summary>
1027
/// Initializes a new instance of the <see cref="ChannelFailureMessage"/> class.
1128
/// </summary>

src/Renci.SshNet/Messages/Connection/ChannelOpen/ChannelOpenMessage.cs

+18-3
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,28 @@ namespace Renci.SshNet.Messages.Connection
66
/// <summary>
77
/// Represents SSH_MSG_CHANNEL_OPEN message.
88
/// </summary>
9-
[Message("SSH_MSG_CHANNEL_OPEN", MessageNumber)]
109
public class ChannelOpenMessage : Message
1110
{
12-
internal const byte MessageNumber = 90;
13-
1411
private byte[] _infoBytes;
1512

13+
/// <inheritdoc />
14+
public override string MessageName
15+
{
16+
get
17+
{
18+
return "SSH_MSG_CHANNEL_OPEN";
19+
}
20+
}
21+
22+
/// <inheritdoc />
23+
public override byte MessageNumber
24+
{
25+
get
26+
{
27+
return 90;
28+
}
29+
}
30+
1631
/// <summary>
1732
/// Gets the type of the channel as ASCII encoded byte array.
1833
/// </summary>

0 commit comments

Comments
 (0)