Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-install deps when creating a new TypeScript Srcbook #249

Closed
nichochar opened this issue Sep 4, 2024 · 2 comments
Closed

Auto-install deps when creating a new TypeScript Srcbook #249

nichochar opened this issue Sep 4, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@nichochar
Copy link
Contributor

Currently, when you create a new TypeScript Srcbook, you are prompted to manually install deps through the modal:
CleanShot 2024-09-03 at 19 41 23

The deps (see screenshot below) need to be installed before any cell can be run. There's no huge security risk since these are default packages that we hardcode into the app, and they are being installed into a new, clean directory.
CleanShot 2024-09-03 at 19 41 29

Therefore, we should simply auto-install them.

The only consideration is a future one: in the future we might want to open Srcbooks "within a directory", and that directory might already have a package.json and node_modules/. That being said, premature optimization is the root of all badness so we can mostly ignore this, unless there are some obvious wins to prepare for it as the auto-install is written.

@nichochar nichochar added the good first issue Good for newcomers label Sep 4, 2024
@benjreinhart
Copy link
Contributor

This is a duplicate of #210, can you close one?

@nichochar
Copy link
Contributor Author

Yeah, closing this one. Dupe of #210

@nichochar nichochar closed this as not planned Won't fix, can't repro, duplicate, stale Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants