Skip to content

Commit 89e4c7b

Browse files
[FIX]:323 - Stopping the cell crashes the server with uncaught error (#334)
1 parent dd4559e commit 89e4c7b

File tree

2 files changed

+16
-4
lines changed

2 files changed

+16
-4
lines changed

.changeset/two-sheep-ring.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@srcbook/api': patch
3+
---
4+
5+
fix server crash when stopping the cell

packages/api/server/ws.mts

+11-4
Original file line numberDiff line numberDiff line change
@@ -319,11 +319,18 @@ async function cellStop(payload: CellStopPayloadType, context: SessionsContextTy
319319
},
320320
});
321321

322-
const killed = processes.kill(session.id, cell.id);
323-
324-
if (!killed) {
322+
try {
323+
const killed = processes.kill(session.id, cell.id);
324+
if (!killed) {
325+
console.warn(
326+
`Process for session ${session.id} and cell ${cell.id} could not be killed. It may have already finished executing.`,
327+
);
328+
}
329+
} catch (e) {
330+
const error = e as unknown as Error;
325331
console.error(
326-
`Attempted to kill process for session ${session.id} and cell ${cell.id} but it didn't die`,
332+
`Error occurred while trying to kill process for session ${session.id} and cell ${cell.id}:`,
333+
error instanceof Error ? error.message : String(error),
327334
);
328335
}
329336
}

0 commit comments

Comments
 (0)