Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test how lookout behaves with draft PRs on github #596

Closed
smacker opened this issue Mar 20, 2019 · 1 comment · Fixed by #615
Closed

test how lookout behaves with draft PRs on github #596

smacker opened this issue Mar 20, 2019 · 1 comment · Fixed by #615
Assignees

Comments

@smacker
Copy link
Contributor

smacker commented Mar 20, 2019

github doesn't run anything on draft prs (most probably it doesn't send notification to github apps).
but lookout doesn't use hooks. We need to test it doesn't post comments to draft prs (to be consistent with all other apps) and does post when status changed to "ready for review"

@smacker smacker self-assigned this Apr 2, 2019
@smacker
Copy link
Contributor Author

smacker commented Apr 2, 2019

Lookout treats Draft PRs as normal PRs and posts comments. Example: https://github.com/smacker/lookout-test/pull/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant