Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings on docker-compose pull #384

Closed
erizocosmico opened this issue Dec 4, 2018 · 2 comments · Fixed by #405
Closed

Warnings on docker-compose pull #384

erizocosmico opened this issue Dec 4, 2018 · 2 comments · Fixed by #405
Assignees
@dpordomingo
Labels
empathy-sessions Issue filed as as part of empathy sessions enhancement New feature or request

Comments

@erizocosmico
Copy link

These warnings are printed when you use docker-compose pull as described in the README. It may be a little weird for the user to see them when at no point they're said to be required.

WARNING: The GITHUB_USER variable is not set. Defaulting to a blank string.
WARNING: The GITHUB_TOKEN variable is not set. Defaulting to a blank string.
@dpordomingo dpordomingo mentioned this issue Dec 10, 2018
Merged
@dpordomingo
Copy link
Contributor

@erizocosmico this issue should be addressed by #405

@dpordomingo dpordomingo self-assigned this Dec 10, 2018
@dpordomingo dpordomingo added enhancement New feature or request empathy-sessions Issue filed as as part of empathy sessions labels Dec 10, 2018
@dpordomingo
Copy link
Contributor

already merged into master
feel free to reopen if it does not fit you @erizocosmico

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpordomingo dpordomingo

Labels
empathy-sessions Issue filed as as part of empathy sessions enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set defaults for GITHUB_USER and GITHUB_TOKEN dpordomingo/lookout
2 participants
@erizocosmico @dpordomingo