Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are no stats for files without lang #94

Open
dpordomingo opened this issue Nov 6, 2018 · 2 comments
Open

There are no stats for files without lang #94

dpordomingo opened this issue Nov 6, 2018 · 2 comments
Labels
empathy-sessions Issue filed as as part of empathy sessions

Comments

@dpordomingo
Copy link

The sum of LANGS_FILES_COUNT is less than FILE_COUNT when a repository contains files wit no language detected.

In such cases, there are no stats about their size, number of lines or the amount of empty lines inside them; reported by LANGS_BYTE_COUNT, LANGS_LINES_COUNT, LANGS_FILES_COUNT, EMPTY_LINES_COUNT.

If it would be added a language unknown to the LANGS list (for example), those cases would be fully covered.

@vmarkovtsev
Copy link
Collaborator

@dpordomingo As far as I understand, unknown can be easily calculated by the 101 arithmetics you described, so not sure if it adds any value.

@dpordomingo
Copy link
Author

To do the maths it would be needed three extra properties, providing the totals for bytes, lines and empty lines;
ie: bytesCount, linesCount, emptyLinesCount

otherwise we can not do the maths, can we?

Current PGA returns for one repo:

{
    "url": "https://github.com/heroku/heroku-buildpack-scala",
    "sivaFilenames": ["eb7aa1e50236c65bf44529ebb9a75fae68e1d6b0.siva"],
    "license": "MIT:0.994",
    "langs": ["JSON", "Markdown", "Ruby", "Scala", "Shell", "Text", "YAML"],
    "langsByteCount": [585, 5528, 6850, 494, 69595, 1070, 711],
    "langsLinesCount": [23, 160, 229, 22, 2425, 10, 32],
    "langsFilesCount": [1, 2, 5, 2, 18, 1, 2],
    "emptyLinesCount": [0, 58, 19, 2, 0, 0, 1],
    "codeLinesCount": [22, 100, 112, 18, 0, 0, 29],
    "commentLinesCount": [0, 0, 8, 0, 0, 0, 0],
    "fileCount": 33,
    "commitsCount": 560,
    "branchesCount": 206,
    "forkCount": 0
}

@smola smola added the empathy-sessions Issue filed as as part of empathy sessions label Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
empathy-sessions Issue filed as as part of empathy sessions
Projects
None yet
Development

No branches or pull requests

3 participants