move Config::$settings description to class annotations #2864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vv12131415
changed the title
Contributor
|
Just a note: something weird is going on as Travis isn't building this PR, even though their status page says all systems are operational. |
Contributor
Author
|
Anything that I can do with this issue? |
Contributor
|
@vladyslavstartsev You may want to try to force-push the branch again to see if that gets the Travis build running. May just have been a hickup in the system. |
vv12131415
force-pushed
the
config-settings-docblock
branch
from
135b57b to
982593d
Compare
vv12131415
force-pushed
the
config-settings-docblock
branch
2 times, most recently
from
40928aa to
6d8c1b6
Compare
vv12131415
force-pushed
the
config-settings-docblock
branch
from
6d8c1b6 to
51d4409
Compare
Contributor
Author
|
I've managed to be unflagged by Travis team If this happens again here, here is the link https://travis-ci.community/t/some-pr-are-not-analyzed-with-message-abuse-detected/1191 |
Contributor
@vladyslavstartsev Glad to hear it ;-) |
gsherwood
added a commit
that referenced
this pull request
Feb 17, 2020
gsherwood
pushed a commit
that referenced
this pull request
Feb 17, 2020
Member
|
Thanks for doing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2861
I've moved description from property comment to class level annotaion