Tokenizer/PHP: bug fix - parent/static keywords in class instantiations #3546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up on 3484 Just like `new class`, `new parent`, `new self` and `new static` should also be preserved and with the `parent`, `self` and `static` keywords remaining as their dedicated token. * For `new static`, the tokenization changed due to the context sensitive keywords change. This has now been fixed. * `new self` was fine before and is still fine. * `new parent` apparently wasn't handled correctly, even before the change. The condition which was in place for handling the same situation for `self` has now been updated to also handle `parent`. Includes unit tests.
|
@gsherwood Could this PR please be milestoned to 3.7.0 ? |
|
Thanks for fixing this |
jrfnl
deleted the
feature/tokenizer-php-bugfix-context-sensitive-keywords
branch
This was referenced Jun 23, 2022
This was referenced Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #3484 /cc @kukulich
Just like
new class,new parent,new selfandnew staticshould also be preserved and with theparent,selfandstatickeywords remaining as their dedicated token.new static, the tokenization changed due to the context sensitive keywords change. This has now been fixed.new selfwas fine before and is still fine.new parentapparently wasn't handled correctly, even before the change. The condition which was in place for handling the same situation forselfhas now been updated to also handleparent.Includes unit tests.