Squiz.Formatting.OperatorBracket duplicate error messages for unary minus #3258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arameters ... to confirm that the sniff does not break on these.
The new test was giving _three_ instead of _two_ errors on line 194 for this snippet `$padding * -1 + 3`, with the errors being thrown on the `*`, `-` and the `+` operators. The `-` operator, however, is a unary operator and should not trigger this error. Fixed now.
gsherwood
changed the title
|
Thanks for fixing this bug, and for those additional test cases. |
jrfnl
deleted the
feature/squiz-operatorbracket-bugfix-and-named-param-tests
branch
|
You're welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.0 | Squiz/OperatorBracket: add tests with named function call parameters
... to confirm that the sniff does not break on these.
Squiz/OperatorBracket: bug fix - improve recognition of unary minus
The new test was giving three instead of two errors on line 194 for this snippet
$padding * -1 + 3, with the errors being thrown on the*,-and the+operators.The
-operator, however, is a unary operator and should not trigger this error.Fixed now.