Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File::isReference() does not detect return by reference for closures #2977

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented May 31, 2020

The & in a closure declared to return by reference was not recognized as a reference.

Fixed now.

Includes unit test.

…ized

The `&` in a closure declared to return by reference was not recognized as a reference.

Fixed now.

Includes unit test.
@gsherwood gsherwood added this to the 3.5.6 milestone Jun 11, 2020
@gsherwood gsherwood changed the title File::isReference(): bug fix - closure return by reference not recognized File::isReference() does not detect return by reference for closures Jun 22, 2020
gsherwood added a commit that referenced this pull request Jun 22, 2020
@gsherwood gsherwood merged commit 57a67b0 into squizlabs:master Jun 22, 2020
@gsherwood
Copy link
Member

Nice find. Thanks for fixing this.

@jrfnl jrfnl deleted the feature/isreference-bugfix-closure-return-by-reference branch June 22, 2020 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants