Squiz.Scope.MemberVarScope throws fatal error when a property is found in an interface #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in an interface
[Fixer conflicts series PR]
Encountered this fatal error when running the `Squiz` standard over the `Squiz` tests files.
The error can be reproduced on `master` by running `phpcs -p -s ./src/Standards/Squiz/Tests/Classes/ValidClassNameUnitTest.inc --standard=Squiz --sniffs=Squiz.Scope.MemberVarScope`
```
Fatal error: Uncaught PHP_CodeSniffer\Exceptions\RuntimeException: Undefined index: scope_specified in /PHPCS/src/Standards/Squiz/Sniffs/Scope/MemberVarScopeSniff.php on line 33 in /PHPCS/src/Runner.php on line 562
PHP_CodeSniffer\Exceptions\RuntimeException: Undefined index: scope_specified in /PHPCS/src/Standards/Squiz/Sniffs/Scope/MemberVarScopeSniff.php on line 33 in /PHPCS/src/Runner.php on line 562
Call Stack:
0.0000 349528 1. {main}() \PHP_CodeSniffer\bin\phpcbf:0
0.0050 511904 2. PHP_CodeSniffer\Runner->runPHPCBF() /PHPCS/bin/phpcbf:18
0.7440 5897360 3. PHP_CodeSniffer\Runner->run() /PHPCS/src/Runner.php:193
0.7720 6565784 4. PHP_CodeSniffer\Runner->processFile() /PHPCS/src/Runner.php:394
1.6731 7023360 5. PHP_CodeSniffer\Reporter->cacheFileReport() /PHPCS/src/Runner.php:611
1.6731 7041328 6. PHP_CodeSniffer\Reports\Cbf->generateFileReport() /PHPCS/src/Reporter.php:284
1.6731 7024896 7. PHP_CodeSniffer\Fixer->fixFile() /PHPCS/src/Reports/Cbf.php:48
1.6981 7048032 8. PHP_CodeSniffer\Files\LocalFile->process() /PHPCS/src/Fixer.php:174
1.6981 7048032 9. PHP_CodeSniffer\Files\LocalFile->process() /PHPCS/src/Files/LocalFile.php:91
1.9421 7421832 10. PHP_CodeSniffer\Standards\Squiz\Sniffs\Scope\MemberVarScopeSniff->process() /PHPCS/src/Files/File.php:490
1.9421 7421832 11. PHP_CodeSniffer\Standards\Squiz\Sniffs\Scope\MemberVarScopeSniff->processTokenWithinScope() /PHPCS/src/Sniffs/AbstractScopeSniff.php:138
1.9421 7422104 12. PHP_CodeSniffer\Standards\Squiz\Sniffs\Scope\MemberVarScopeSniff->processMemberVar() /PHPCS/src/Sniffs/AbstractVariableSniff.php:145
1.9421 7422544 13. PHP_CodeSniffer\Runner->handleErrors() /PHPCS/src/Standards/Squiz/Sniffs/Scope/MemberVarScopeSniff.php:33
```
Includes unit test to safeguard against this in the future.
gsherwood
changed the title
|
Thanks for this fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fixer conflicts series PR]
Encountered this fatal error when running the
Squizstandard over theSquiztests files.The error can be reproduced on
masterby runningphpcs -p -s ./src/Standards/Squiz/Tests/Classes/ValidClassNameUnitTest.inc --standard=Squiz --sniffs=Squiz.Scope.MemberVarScopeIncludes unit test to safeguard against this in the future.